[Addon] Update to Flux2 (fix conflicts) #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
andrea-berling
requested review from
wangyikewxgm,
FogDong and
charlie0129
as code owners
|
What's the hold up on upgrading to flux 2? |
|
Not adopting Flux v2 is likely holding back adoption of KubeVela. |
wonderflow
approved these changes
Jun 15, 2024
|
thanks, ping @FogDong |
FogDong
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is exactly the same as #722, with the merge conflicts resolved. Anything in the description and the comments of that MR applies to this one as well. I forked off and fixed the conflicts myself (which were, btw, just on the version number of the plugin in
metadata.yaml) because it seems like the original author (@kichristensen) moved on to a different project and forgot about this. Hope this expedites the merging and upgrade of the flux addon