Test:Add unit test of triggerinstance controller #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mcduller <1596582524@qq.com>
|
Actually, you don't need to close your pr if the check fails (or if there any special reason that you need to close this?) |
ok,I got it ,i will reopen it |
Signed-off-by: Mcduller <1596582524@qq.com>
… trigger_instance_unit_test # Conflicts: # controllers/triggerinstance/suite_test.go # controllers/triggerinstance/triggerinstance_controller_test.go # pkg/util/test_utils.go
|
@charlie0129 hi, I had fix the check error, could you review this pr ? |
charlie0129
reviewed
Sep 29, 2022
| LeaderElectionNamespace: "default", | ||
| LeaderElectionID: "test", | ||
| }) | ||
| var done = make(chan interface{}) |
There was a problem hiding this comment.
What does this
donedo?
It's redundant, i will remove it.
Signed-off-by: Mcduller <1596582524@qq.com>
… trigger_instance_unit_test
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
* Test:Add unit test of triggerinstance controller Signed-off-by: Mcduller <1596582524@qq.com> * Test:Add unit test of triggerinstance controller Signed-off-by: Mcduller <1596582524@qq.com> Signed-off-by: Mcduller <1596582524@qq.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the normal case about creating triggerinstance and relevant resource of triggerinstance controller
Signed-off-by: Mcduller 1596582524@qq.com