-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: refactor filter and action with cuex #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie0129
reviewed
Jan 30, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
charlie0129
approved these changes
Jan 30, 2023
Somefive
reviewed
Jan 30, 2023
|
||
// ApplyFilter applies the given filter to an object. | ||
func ApplyFilter(ctx context.Context, contextData map[string]interface{}, filter string) (bool, error) { | ||
contextByte, err := json.Marshal(contextData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably make some common functions in kubevela/pkg which accept template and contextData as input and generate cue.Value. It is commonly used across trigger/workflowstep/component/trait, etc.
Somefive
approved these changes
Jan 31, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
* Chore: refactor filter and action with cuex Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * resolve comments Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> --------- Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com
Description of your changes
This PR refactors the filter and action with cuex.
The trigger is as below:
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer