Feat: support multi cluster for source watcher #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
charlie0129
reviewed
Feb 7, 2023
| return nil, err | ||
| } | ||
| if len(clusters) == 0 { | ||
| req, err := labels.NewRequirement(clusterLabel, selection.Exists, nil) |
There was a problem hiding this comment.
Does this mean it requires cluster-gateway to function?
There was a problem hiding this comment.
It requires a cluster-gateway typed X509 secret but does not need a cluster-gateway. This is a temporary implementation.
Somefive
approved these changes
Feb 8, 2023
|
Will refactor this implementation to an interface and make |
semmet95
pushed a commit
to semmet95/kube-trigger
that referenced
this pull request
May 10, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> Signed-off-by: Amit Singh <singhamitch@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer