Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix release action #33

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fix: fix release action #33

merged 4 commits into from
Feb 14, 2023

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Feb 13, 2023

Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com

Description of your changes

  • fix a regression that GitHub Action will fail because of a wrong make target
  • move build cache into dot directory to skip go mod recursive search
  • make sed work on macOS
  • make container-build always target linux

I have:

  • Read and followed KubeVela's contribution process.
  • Add related tests.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 force-pushed the fix-release branch 2 times, most recently from 102a638 to de9bd6e Compare February 13, 2023 14:19
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@FogDong FogDong merged commit 50e12b1 into kubevela:main Feb 14, 2023
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
* fix release

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* sed macOS fix

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* move build cache into .go to skip indexing

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* make container target os always linux

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

---------

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
semmet95 pushed a commit to semmet95/kube-trigger that referenced this pull request May 10, 2023
* fix release

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* sed macOS fix

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* move build cache into .go to skip indexing

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

* make container target os always linux

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>

---------

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants