Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: example manager and instructions #48

Merged
merged 12 commits into from
May 19, 2023
Merged

Fix: example manager and instructions #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a22e316
Feat: upgrade k8s.io dependency to 0.26 (#39)
Somefive Apr 3, 2023
e214be5
Feat: add cluster info to action context (#43)
yangsoon Apr 13, 2023
46f5975
Feat: add cronjob source (#42)
charlie0129 Apr 14, 2023
4351008
Feat: support leader election for kube-trigger (#45)
yangsoon Apr 17, 2023
46f4c85
adds instruction to enable kube-trigger addon
semmet95 May 6, 2023
a861aa4
updates sample.yaml path
semmet95 May 6, 2023
3185121
fix: updates instructions to apply config files in order
semmet95 May 6, 2023
b76f491
fix: adds the missing api group to the first rule
semmet95 May 6, 2023
c12520f
Revert "Feat: support leader election for kube-trigger (#45)"
semmet95 May 19, 2023
e774f3d
Revert "Feat: add cronjob source (#42)"
semmet95 May 19, 2023
f6a79de
Revert "Feat: add cluster info to action context (#43)"
semmet95 May 19, 2023
b358fd1
Revert "Feat: upgrade k8s.io dependency to 0.26 (#39)"
semmet95 May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion config/manager/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ metadata:
creationTimestamp: null
name: kube-trigger-manager-role
rules:
- resources:
- apiGroups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is auto generated, can you help to check that is there anything wrong with the generator? cc @charlie0129

Copy link
Member

@charlie0129 charlie0129 May 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. Maybe newer versions of kubectl require apiGroups to be set.

I fixed the generator to generate that field in the latest commit.

- ""
resources:
- configmaps
verbs:
- get
Expand Down
10 changes: 8 additions & 2 deletions examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ updated whenever the ConfigMaps that are referenced by `ref-objects` are updated
## Prerequisites

- Install [KubeVela](https://kubevela.net/docs/install) in your cluster
- Enable the `kube-trigger` addon
```shell
vela addon enable kube-trigger
```

## What we want to achieve?

Expand All @@ -26,7 +30,7 @@ Apply `sample.yaml` to create 2 Applications and 2 ConfigMaps in the default nam
trigger 2 Application updates.

```shell
kubectl apply sample.yaml
kubectl apply -f examples/sample.yaml
```

2. **Run kube-trigger**
Expand All @@ -43,7 +47,9 @@ Standalone:
In-Cluster:

```shell
kubectl apply -f config/
kubectl apply -f config/crd/
kubectl apply -f config/definition/
kubectl apply -f config/manager/
```

3. **Watch ApplicationRevision changes** so that you can see what it does.
Expand Down