Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Amend hashicorp filtering #1607

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 19, 2023

What this PR does / why we need it:
According [1] we need to look on go.mod only because we have "go 1.17" in go.mod.
Adapt git actions accordingly.

Special notes for your reviewer:
All the 3 modules whitelisted on this PR are approved by GB exception, example [2]
More reading about it [3]

[1] cncf/foundation#617 (comment)
[2] https://github.com/cncf/foundation/blob/e8bd39f52b9b577a0ba2fcb2bfa8e68b35ebc1e8/license-exceptions/cncf-exceptions-2022-04-12.json#L80
[3] cncf/foundation#617 (comment)

Release note:

None

The go VER line was there, but not in the beginning as it should.

Signed-off-by: Or Shoval <oshoval@redhat.com>
According cncf/foundation#617 (comment)
we need to look on go.mod only because we have "go 1.17" in go.mod.
Adapt git actions accordingly.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 19, 2023

/cc @RamLavi @phoracek

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 19, 2023

/cc @dhiller
wdyt ?

@qinqon
Copy link
Collaborator

qinqon commented Sep 19, 2023

/lgtm
/approve
/override pull-e2e-cnao-multus-dynamic-networks-functests

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-e2e-cnao-multus-dynamic-networks-functests

In response to this:

/lgtm
/approve
/override pull-e2e-cnao-multus-dynamic-networks-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@kubevirt-bot kubevirt-bot merged commit 84ad96e into kubevirt:main Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants