Introduce new SIG governance and tooling #236

lyarwood · 2023-08-08T17:27:21Z

This PR is the outcome of the SIGs - What's Next? calls happening below:

https://docs.google.com/document/d/1yOtxWS2eIgA2VT71NbFaDEzGyVfmiDCwoRBHKow0K6c/edit

At present this series aims to:

kubevirt-bot · 2023-08-08T17:27:23Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

kubevirt-bot · 2023-08-08T17:27:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cwilkers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

iholder101 · 2023-08-10T12:05:29Z

/cc

dhiller · 2023-08-10T13:19:39Z

@lyarwood please note that the sigs.yaml file is required to update the CNCF stats for KubeVirt.

I will need to check whether the changes impact the stats generation.

/assign

dhiller · 2023-08-10T13:19:56Z

/cc

dhiller · 2023-08-14T10:26:21Z

/test ?

kubevirt-bot · 2023-08-14T10:26:24Z

@dhiller: The following commands are available to trigger required jobs:

/test pull-community-generate-kubevirt-devstats-repo-sql
/test pull-community-validate-sigs-yaml

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhiller · 2023-08-14T10:26:35Z

/test pull-community-generate-kubevirt-devstats-repo-sql
/test pull-community-validate-sigs-yaml

sigs.yaml

GOVERNANCE.md

dhiller

I've noticed that we are missing some labels in the config, therefore I've created a WIP PR: kubevirt/project-infra#2953

Other than that looks good to me.

sigs.yaml

GOVERNANCE.md

kubevirt-bot · 2023-08-23T16:18:26Z

New changes are detected. LGTM label has been removed.

lyarwood · 2023-08-23T18:08:06Z

/hold

I'm likely going to break this up into a few different PRs after the call tomorrow.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

lyarwood · 2023-09-14T14:41:43Z

/unhold

As discussed in the latest SIGs - What's Next? [1] meeting I think the PR is getting to the stage now where we should land what we have and work to refine it through engaging the existing SIGs to populate the required metadata.

I'm hopeful that this process will help us iron out any issues and nits with the process instead of this PR forever being in review and not moving the overall SIG process forward.

Once merged I'm going to use the SIGs - What's Next? call to help on-board folks into the process and set out what is required going forward.

[1] https://docs.google.com/document/d/1yOtxWS2eIgA2VT71NbFaDEzGyVfmiDCwoRBHKow0K6c/edit

aburdenthehand

Great work, @lyarwood
I've done a run through and picked up some changes re: steering committee and some kubernetes info, and updated the slack channels etc. I've also tried to slim down some of the weight that I don't think applies to our project.

aburdenthehand · 2023-09-15T13:46:27Z

GOVERNANCE.md

+* Horizontal: Scalability, Architecture
+* Project: Testing, Release, Docs
+
+SIGs must have at least one and ideally two SIG chairs at any given time. SIG chairs are intended to be organizers and facilitators, responsible for the operation of the SIG and for communication and coordination with the other SIGs, the Steering Committee, and the broader community.


As I understand it, at this stage we would prefer a 'SIG Governance' or similar to help out with process and decision making of creating/maintaining SIGs rather than a steering committee.
This line then might be better as "...coordination with the other SIGs, particularly SIG Governance, and the broader..." or similar.

There's 40-odd references to steering committee in this PR atm which we should probably change (or remove the file entirely).

aburdenthehand · 2023-09-15T13:50:25Z

liaisons.md

+
+# Liaisons
+
+Steering Committee members are elected representatives of the kubevirt


We could probably drop this file for the time being, as any SIG should be able to reach out to any of the SIG-governance members, no?

aburdenthehand · 2023-09-15T13:51:52Z

sig-charter-guide.md

+ and a link to the PR in the body.
+8. Typically expect feedback within a week of sending your draft. Expect longer time if it falls over an
+ event such as KubeCon/CloudNativeCon or holidays. Make any necessary changes.
+9. Once accepted, the steering committee will ratify the PR by merging it.


Suggested change

9. Once accepted, the steering committee will ratify the PR by merging it.

9. Once accepted, a member of SIG Governance will ratify the PR by merging it.

aburdenthehand · 2023-09-15T13:53:39Z

sig-charter-guide.md

+## Steps to update an existing SIG charter
+
+- For significant changes, or any changes that could impact other SIGs, such as the scope, create a
+ PR and send it to the steering committee for review with the subject: "SIG Charter Update: YOURSIG"


Suggested change

PR and send it to the steering committee for review with the subject: "SIG Charter Update: YOURSIG"

PR and tag `sig-governance` for review.

?

aburdenthehand · 2023-09-15T13:55:30Z

sig-charter-guide.md

+ Make sure to keep the SIG in the loop as discussions progress with the Steering Committee (next step).
+ Including the SIG mailing list in communications with the steering committee would work for this.
+- Work with the steering committee (Approvers) to gain approval.
+ This can simply be submitting a PR and sending mail to [kubevirt-dev@googlegroups.com].


Suggested change

Make sure to keep the SIG in the loop as discussions progress with the Steering Committee (next step).

Including the SIG mailing list in communications with the steering committee would work for this.

- Work with the steering committee (Approvers) to gain approval.

This can simply be submitting a PR and sending mail to [kubevirt-dev@googlegroups.com].

- Work with SIG Governance maintainers to gain approval.

aburdenthehand · 2023-09-15T15:02:57Z

tools/sigs/generator/README.md

+- WG README: [`wg_readme.tmpl`](wg_readme.tmpl)
+- Committee README: [`committee_readme.tmpl`](committee_readme.tmpl)
+
+**Time Zone gotcha**:


Using UTC removes the issue of daylight savings, and the KubeVirt calendar updates times depending on the user/browser location.

aburdenthehand · 2023-09-15T15:03:46Z

tools/sigs/generator/annual-report/github_issue.tmpl

@@ -0,0 +1,35 @@
+{{lastYear}} Annual Report: {{.Prefix | toUpper}} {{.Name}}


Do we need these three annual report files?

aburdenthehand · 2023-09-15T15:06:08Z

tools/sigs/generator/committee_readme.tmpl

+{{- if .Contact.Liaison.Name }}
+- Steering Committee Liaison: {{.Contact.Liaison.Name}} (**[@{{.Contact.Liaison.GitHub}}](https://github.com/{{.Contact.Liaison.GitHub}})**)
+{{- end }}


I'd say we can drop these lines

aburdenthehand · 2023-09-15T15:06:40Z

tools/sigs/generator/liaisons.tmpl

@@ -0,0 +1,45 @@
+{{ template "header" }}


As before, I don't think we need specific liaisons

aburdenthehand · 2023-09-15T15:07:22Z

tools/sigs/generator/sig_readme.tmpl

+{{- end }}
+
+## Contact
+- Slack: [#{{.Contact.Slack}}](https://kubevirt.slack.com/messages/{{.Contact.Slack}})


Suggested change

- Slack: [#{{.Contact.Slack}}](https://kubevirt.slack.com/messages/{{.Contact.Slack}})

- Slack: [#{{.Contact.Slack}}](https://kubernetes.slack.com/messages/kubevirt-dev{{.Contact.Slack}})

kubevirt-bot · 2023-12-14T15:46:50Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot · 2024-01-13T15:58:54Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

lyarwood · 2024-02-26T13:47:57Z

/close

See https://groups.google.com/g/kubevirt-dev/c/dXvwU6Pon7Y for more context.

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 8, 2023

kubevirt-bot requested review from jean-edouard and jobbler August 8, 2023 17:27

kubevirt-bot added the size/L label Aug 8, 2023

kubevirt-bot requested a review from iholder101 August 10, 2023 12:05

kubevirt-bot assigned dhiller Aug 10, 2023

kubevirt-bot requested a review from dhiller August 10, 2023 13:19

dhiller requested changes Aug 14, 2023

View reviewed changes

sigs.yaml Show resolved Hide resolved

sigs.yaml Outdated Show resolved Hide resolved

dhiller mentioned this pull request Aug 17, 2023

Contact project maintainers for stale projects and ask them whether it is safe to archive these #239

Open

lyarwood force-pushed the sigs branch from 1af6e54 to 862167f Compare August 17, 2023 09:29

iholder101 reviewed Aug 23, 2023

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

GOVERNANCE.md Show resolved Hide resolved

dhiller approved these changes Aug 23, 2023

View reviewed changes

sigs.yaml Outdated Show resolved Hide resolved

sigs.yaml Outdated Show resolved Hide resolved

sigs.yaml Outdated Show resolved Hide resolved

sigs.yaml Outdated Show resolved Hide resolved

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023

dhiller mentioned this pull request Aug 23, 2023

Add labels for sigs kubevirt/project-infra#2953

Merged

aburdenthehand reviewed Aug 23, 2023

View reviewed changes

GOVERNANCE.md Outdated Show resolved Hide resolved

lyarwood force-pushed the sigs branch from 862167f to b410205 Compare August 23, 2023 16:18

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023

kubevirt-bot added size/XXL and removed size/L labels Aug 23, 2023

lyarwood added 13 commits September 14, 2023 14:34

sigs: Remove sig-userinterface

4ca6edf

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Add sig-release

0347d6b

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: run validators/cmd/sigs/sigs-validator.go

88f0621

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Fix labels

bba6c7f

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Add docs from k8s

a11b284

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Update sig-goverance.md for KubeVirt

7381e3b

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Update sig-governance-requirements.md for KubeVirt

ff28a2f

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Update sig-charter-guide.md for KubeVirt

8d3f348

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Update sig-charter-template.md for KubeVirt

5d688b8

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Update sig-lifecycle.md for KubeVirt

75a41d0

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

tools: Add sig generator tooling from k8s

32e93ed

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

tools: Update sigs generator templates for KubeVirt

b778d15

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

sigs: Run make generate

2bee0a7

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

lyarwood force-pushed the sigs branch from b410205 to 2bee0a7 Compare September 14, 2023 13:43

lyarwood mentioned this pull request Sep 14, 2023

WIP Introduce SIG Governance #244

Closed

lyarwood changed the title ~~WIP - Update SIGs~~ Introduce new SIG governance and tooling Sep 14, 2023

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023

lyarwood marked this pull request as ready for review September 14, 2023 14:41

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023

aburdenthehand reviewed Sep 15, 2023

View reviewed changes

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2023

kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 13, 2024

aburdenthehand added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 31, 2024

lyarwood closed this Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce new SIG governance and tooling #236

Introduce new SIG governance and tooling #236

lyarwood commented Aug 8, 2023 •

edited

Loading

kubevirt-bot commented Aug 8, 2023

kubevirt-bot commented Aug 8, 2023

iholder101 commented Aug 10, 2023

dhiller commented Aug 10, 2023

dhiller commented Aug 10, 2023

dhiller commented Aug 14, 2023

kubevirt-bot commented Aug 14, 2023

dhiller commented Aug 14, 2023

dhiller left a comment •

edited

Loading

kubevirt-bot commented Aug 23, 2023

lyarwood commented Aug 23, 2023

lyarwood commented Sep 14, 2023

aburdenthehand left a comment

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

aburdenthehand Sep 15, 2023

kubevirt-bot commented Dec 14, 2023

kubevirt-bot commented Jan 13, 2024

lyarwood commented Feb 26, 2024


		# Liaisons

		Steering Committee members are elected representatives of the kubevirt

	9. Once accepted, the steering committee will ratify the PR by merging it.
	9. Once accepted, a member of SIG Governance will ratify the PR by merging it.

	PR and send it to the steering committee for review with the subject: "SIG Charter Update: YOURSIG"
	PR and tag `sig-governance` for review.

		@@ -0,0 +1,35 @@
		{{lastYear}} Annual Report: {{.Prefix \| toUpper}} {{.Name}}

	- Slack: [#{{.Contact.Slack}}](https://kubevirt.slack.com/messages/{{.Contact.Slack}})
	- Slack: [#{{.Contact.Slack}}](https://kubernetes.slack.com/messages/kubevirt-dev{{.Contact.Slack}})

Introduce new SIG governance and tooling #236

Introduce new SIG governance and tooling #236

Conversation

lyarwood commented Aug 8, 2023 • edited Loading

kubevirt-bot commented Aug 8, 2023

kubevirt-bot commented Aug 8, 2023

iholder101 commented Aug 10, 2023

dhiller commented Aug 10, 2023

dhiller commented Aug 10, 2023

dhiller commented Aug 14, 2023

kubevirt-bot commented Aug 14, 2023

dhiller commented Aug 14, 2023

dhiller left a comment • edited Loading

Choose a reason for hiding this comment

kubevirt-bot commented Aug 23, 2023

lyarwood commented Aug 23, 2023

lyarwood commented Sep 14, 2023

aburdenthehand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 14, 2023

kubevirt-bot commented Jan 13, 2024

lyarwood commented Feb 26, 2024

lyarwood commented Aug 8, 2023 •

edited

Loading

dhiller left a comment •

edited

Loading