Skip to content

Commit

Permalink
Docs for dataimportcron storage class switching (#3445)
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
  • Loading branch information
akalenyu authored Oct 6, 2024
1 parent 854ec97 commit 0838360
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions doc/datavolumes.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ or implicitly as explained in the previous paragraph), CDI will take the file sy
overhead into account and request a PVC big enough to fit both an image and the file
system metadata. This logic only applies to the `DataVolume.spec.storage`.

#### Default virtualization storage class
If you skip the `storageClassName` parameter, CDI will prioritize the default
virtualization storage class over k8s' default. You can define your default
virtualization storage class by annotating it with
Expand Down
10 changes: 10 additions & 0 deletions doc/os-image-poll-and-update.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,13 @@ spec:
```

To ensure smooth transition, existing DataImportCrons can be switchd to maintaining snapshots instead of PVCs by updating their corresponding storage profiles.

## DataImportCron storage class
Unless specified explicitly, similarly to PVCs, DataImportCrons will be provisioned using the default [virt](./datavolumes.md#default-virtualization-storage-class)/k8s storage class.
In previous versions, an admin would have to actively delete the old sources upon change of the storage class
(either explicitly by editing the DataImportCron or a cluster-wide change of the default storage class)

Today, the controller performs this automatically;
However, changing the storage class should be a conscious decision and in some cases (complex CI setups) it's advised to specify it explicitly
to avoid exercising a different storage class for golden images throughout installation.
This flip flop could be costly and in some cases outright surprising to cluster admins.

0 comments on commit 0838360

Please sign in to comment.