Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Tinycore Functest image multiarch #3628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Tinycore Functest image multiarch #3628

wants to merge 1 commit into from
+6 −0

Conversation

Davo911
Copy link
Contributor

@Davo911 Davo911 commented Feb 5, 2025

What this PR does / why we need it:
Changeup some bazel code to be able to build the tinycore image needed for some functional tests for arm and s390x

Which issue(s) this PR fixes :
Fixes #3627

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 5, 2025
@kubevirt-bot
Copy link
Contributor

Hi @Davo911. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Davo911
Copy link
Contributor Author

Davo911 commented Feb 5, 2025

cc: @cfilleke

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Davo911
Enable Tinycore Functest image multiarch
e59f564 
Changeup some bazel code to be able to build the tinycore image needed for some functional tests for arm and s390x

Signed-off-by: Thomas-David Griedel griedel911@gmail.com
@Davo911 Davo911 force-pushed the tinycore-multiarch branch from 6931054 to e59f564 Compare February 5, 2025 17:59
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude tinycore tests from s390x e2e test suite
2 participants
@Davo911 @kubevirt-bot