Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: checking available image size #3458

Closed
wants to merge 1 commit into from
Closed

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Oct 11, 2024

Signed-off-by: Andrei Kvapil kvapss@gmail.com

What this PR does / why we need it:

This PR fixes the issue of checking size for the end device.

Currently we check if actual block-volume is larger than requested size in PVC.
However we should check if actual block-volume is smaller than requested size in PVC, because this might blocking the image upload.

Which issue(s) this PR fixes:
Fixes #3159

Special notes for your reviewer:

Release note:

Fix: checking available image size

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2024
@kubevirt-bot kubevirt-bot added size/XS release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2024
@kvaps
Copy link
Member Author

kvaps commented Oct 11, 2024

/assign @awels

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from awels. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

@kvaps: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-unit-test c750a2d link false /test pull-cdi-unit-test
pull-cdi-goveralls c750a2d link false /test pull-cdi-goveralls
pull-cdi-unit-test-s390x c750a2d link false /test pull-cdi-unit-test-s390x
pull-containerized-data-importer-e2e-destructive c750a2d link true /test pull-containerized-data-importer-e2e-destructive
pull-containerized-data-importer-e2e-nfs c750a2d link true /test pull-containerized-data-importer-e2e-nfs
pull-containerized-data-importer-e2e-hpp-latest c750a2d link true /test pull-containerized-data-importer-e2e-hpp-latest
pull-containerized-data-importer-e2e-upg c750a2d link true /test pull-containerized-data-importer-e2e-upg
pull-containerized-data-importer-non-csi-hpp c750a2d link true /test pull-containerized-data-importer-non-csi-hpp
pull-containerized-data-importer-e2e-istio c750a2d link true /test pull-containerized-data-importer-e2e-istio
pull-containerized-data-importer-e2e-hpp-previous c750a2d link true /test pull-containerized-data-importer-e2e-hpp-previous
pull-containerized-data-importer-e2e-ceph c750a2d link true /test pull-containerized-data-importer-e2e-ceph
pull-containerized-data-importer-e2e-ceph-wffc c750a2d link true /test pull-containerized-data-importer-e2e-ceph-wffc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kvaps kvaps marked this pull request as draft October 14, 2024 10:42
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@kvaps
Copy link
Member Author

kvaps commented Oct 14, 2024

Closed in favor #3461

@kvaps kvaps closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual image size is larger than the reported available storage
3 participants