-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: checking available image size #3458
Conversation
/assign @awels |
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kvaps: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closed in favor #3461 |
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does / why we need it:
This PR fixes the issue of checking size for the end device.
Currently we check if actual block-volume is larger than requested size in PVC.
However we should check if actual block-volume is smaller than requested size in PVC, because this might blocking the image upload.
Which issue(s) this PR fixes:
Fixes #3159
Special notes for your reviewer:
Release note: