[release-v1.59] Manual backport "Move size detection pod deletion to cleanup" #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
* Correct check deciding whether to delete size detection pod This is probably not the resolving many cases but it does look like an oversight since the size detection pod's appearance is triggered by the target clone request and not the source. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Move size detection pod deletion to cleanup Apparently it's possible that the size detection pod will stick around even if the dv is succeeded/deleted. I think this belongs in the cleanup loop anyway Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Fix datasource watch indexing We slap on the index key regardless of source.PVC/source.Snapshot so it was possible for a DV with PVC source to get queued for the snapshot controller and trigger all sorts of fun nils. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Add datasource watch in snapshot controller as well This is also needed for snapshot clones, guess it just merged around the time they were introduced. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Add check for nil pointers post CI run This should make it easier to spot obvious nil pointers through CI runs. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
delete-size-detection-59
branch
from
a76865d to
c455f3d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #3553
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: