Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDIDataVolumeUnusualRestartCount alert #3630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Feb 6, 2025

What this PR does / why we need it:
This PR Updates CDIDataVolumeUnusualRestartCount alert
and sets the health impact label to "none", since
it only impact specific VMs and not the operator health.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #https://issues.redhat.com/browse/CNV-56026

Special notes for your reviewer:

Release note:

NONE

Update CDIDataVolumeUnusualRestartCount alert.
Set the health impact label to "none", since
it only impact specific VMs and not the operator health.

Signed-off-by: Shirly Radco <sradco@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 6, 2025
@kubevirt-bot kubevirt-bot requested a review from awels February 6, 2025 12:40
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Feb 6, 2025
@sradco
Copy link
Contributor Author

sradco commented Feb 9, 2025

Hi, @avlitman @machadovilaca, Please review this PR.
Thank you.

@sradco
Copy link
Contributor Author

sradco commented Feb 9, 2025

/retest-required

@akalenyu
Copy link
Collaborator

akalenyu commented Feb 9, 2025

/approve
I think a release note makes sense in this case

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2025
@avlitman
Copy link
Contributor

avlitman commented Feb 9, 2025

waiting for release note and will lgtm

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2025
@sradco
Copy link
Contributor Author

sradco commented Feb 10, 2025

@akalenyu @avlitman Hi, I update the release note to "None", since this is a minor update.

@akalenyu
Copy link
Collaborator

/test pull-cdi-goveralls

@coveralls
Copy link

Coverage Status

coverage: 59.432% (-0.02%) from 59.453%
when pulling b361637 on sradco:update_CDIDataVolumeUnusualRestartCount_health_impact_label
into 9e787fe on kubevirt:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants