Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitForFirstConsumer support #116

Open
kvaps opened this issue Jul 18, 2024 · 6 comments
Open

Add WaitForFirstConsumer support #116

kvaps opened this issue Jul 18, 2024 · 6 comments
Labels
kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@kvaps
Copy link
Member

kvaps commented Jul 18, 2024

Is your feature request related to a problem? Please describe:

If you're using storageclass with volumeBindingMode: WaitForFirstConsumer it is not binding volumes and waiting for first usage of the volume:

# k describe pvc -n tenant-k8suser16735  pvc-0db10b63-afb0-49c1-80aa-698761fe5805
Name:          pvc-0db10b63-afb0-49c1-80aa-698761fe5805
Namespace:     tenant-k8suser16735
StorageClass:  replicated
Status:        Pending
Volume:
Labels:        app=containerized-data-importer
               app.kubernetes.io/component=storage
               app.kubernetes.io/managed-by=cdi-controller
               csi-driver/cluster=test
Annotations:   cdi.kubevirt.io/storage.contentType: kubevirt
               cdi.kubevirt.io/storage.deleteAfterCompletion: false
               cdi.kubevirt.io/storage.pod.restarts: 0
               cdi.kubevirt.io/storage.preallocation.requested: false
               cdi.kubevirt.io/storage.usePopulator: true
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Block
DataSource:
  APIGroup:  cdi.kubevirt.io
  Kind:      VolumeImportSource
  Name:      volume-import-source-9971aa28-269b-4baa-89e8-bc651792e7c5
Used By:     <none>
Events:
  Type    Reason                Age                    From                         Message
  ----    ------                ----                   ----                         -------
  Normal  WaitForFirstConsumer  2m16s (x262 over 67m)  persistentvolume-controller  waiting for first consumer to be created before binding
@kvaps kvaps changed the title WaitForFirstConsumer support Add WaitForFirstConsumer support Jul 18, 2024
kvaps added a commit to aenix-io/cozystack-website that referenced this issue Jul 18, 2024
Temprary switch volumeBindingMode to Immediate, due to fact kubevirt-csi does not work with WaitForFirstConsumer yet

kubevirt/csi-driver#116

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/cozystack-website that referenced this issue Jul 18, 2024
Temprary switch volumeBindingMode to Immediate, due to fact kubevirt-csi does not work with WaitForFirstConsumer yet

kubevirt/csi-driver#116

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@awels
Copy link
Member

awels commented Jul 18, 2024

Yes this is a known issue, we have to propagate the WFFC to the tenant storage class as well. I had an open issue explaining some of the issues, just haven't gotten around to it. #66

@kubevirt-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024
@awels
Copy link
Member

awels commented Oct 16, 2024

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024
@kubevirt-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2025
@kubevirt-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 13, 2025
@awels
Copy link
Member

awels commented Feb 13, 2025

/lifecycle frozen

@kubevirt-bot kubevirt-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants