-
Notifications
You must be signed in to change notification settings - Fork 153
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Apply operator-observability rules linter Apply operator-observability rules linter which ensures that kubevirt alerts and recording rules definitions are following the monitoring best practices. Signed-off-by: assafad <aadmi@redhat.com> * Apply monitoringlinter Apply monitoringlinter, which is designed to ensure that in Kubernetes operator projects, monitoring-related practices are implemented within the pkg/monitoring directory using operator-observability methods. Signed-off-by: assafad <aadmi@redhat.com> --------- Signed-off-by: assafad <aadmi@redhat.com>
- Loading branch information
Showing
28 changed files
with
3,162 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package rules | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "github.com/machadovilaca/operator-observability/pkg/testutil" | ||
| ) | ||
|
|
||
| func TestRules(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Rules Suite") | ||
| } | ||
|
|
||
| var _ = Describe("Rules Validation", func() { | ||
| var linter *testutil.Linter | ||
|
|
||
| BeforeEach(func() { | ||
| Expect(SetupRules()).To(Succeed()) | ||
| linter = testutil.New() | ||
| }) | ||
|
|
||
| It("Should validate alerts", func() { | ||
| linter.AddCustomAlertValidations( | ||
| testutil.ValidateAlertNameLength, | ||
| testutil.ValidateAlertRunbookURLAnnotation, | ||
| testutil.ValidateAlertHealthImpactLabel, | ||
| testutil.ValidateAlertPartOfAndComponentLabels) | ||
|
|
||
| alerts := ListAlerts() | ||
| problems := linter.LintAlerts(alerts) | ||
| Expect(problems).To(BeEmpty()) | ||
| }) | ||
|
|
||
| It("Should validate recording rules", func() { | ||
| recordingRules := ListRecordingRules() | ||
| problems := linter.LintRecordingRules(recordingRules) | ||
| Expect(problems).To(BeEmpty()) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 8 additions & 25 deletions
33
...s/vendor/github.com/machadovilaca/operator-observability/pkg/operatormetrics/histogram.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
...ndor/github.com/machadovilaca/operator-observability/pkg/operatormetrics/histogram_vec.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
30 changes: 8 additions & 22 deletions
30
tests/vendor/github.com/machadovilaca/operator-observability/pkg/operatormetrics/summary.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
...vendor/github.com/machadovilaca/operator-observability/pkg/operatormetrics/summary_vec.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.