Fix golangcli-lint issue

[erkanerol]

Signed-off-by: Erkan Erol eerol@redhat.com

We are hitting golangci/golangci-lint-action#135 in our checks. This PR disables some functionalities of the linter as a workaround shared here: golangci/golangci-lint-action#135 (comment)

Reviewer Checklist

• PR Message
• Commit Messages
• How to test
• Unit Tests
• Functional Tests
• User Documentation
• Developer Documentation
• Upgrade Scenario
• Uninstallation Scenario
• Backward Compatibility
• Troubleshooting Friendly

Release note:

NONE

[nunnatsa]

pr-sanity action didn't run. It seems that the file indentation is wrong.

[nunnatsa]

Failed because of linter timeout.

Let's take out the temp kubevirt directory. Maybe also the tests directory.

[tiraboschi]

Failed because of linter timeout.

Let's take out the temp kubevirt directory. Maybe also the tests directory.

on my machine it's running in 1 second:

stirabos@t14s:~/go/src/github.com/kubevirt/hyperconverged-cluster-operator$ time golangci-lint run
real	0m0,936s
user	0m3,169s
sys	0m0,418s

while the github action is failing due to timeout after 98s

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.8% Duplication

[coveralls]

Pull Request Test Coverage Report for Build 770587678

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 72.202%

---

Totals
Change from base Build 770516980:	0.0%
Covered Lines:	2922
Relevant Lines:	4047

---

💛 - Coveralls

[erkanerol]

I increased the timeout from 1m to 5m. I am checking the stability and possible configurations.

[nunnatsa]

on my machine it's running in 1 second:

stirabos@t14s:~/go/src/github.com/kubevirt/hyperconverged-cluster-operator$ time golangci-lint run
real	0m0,936s
user	0m3,169s
sys	0m0,418s

Local caching?

[nunnatsa]

I increased the timeout from 1m to 5m. I am checking the stability and possible configurations.

I still think we don't need to check the whole project.

[erkanerol]

I increased the timeout from 1m to 5m. I am checking the stability and possible configurations.

I still think we don't need to check the whole project.

According to my tests, it doesn't check the kubevirt directory. However, it does check tests. I prefer checking tests as well since we need to ensure the quality of the tests as well.

[tiraboschi]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nunnatsa]

/lgtm
/approve