Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-label-visualizer: try KUBECONFIG first #1844

Merged
merged 1 commit into from
Mar 31, 2022
Merged

k8s-label-visualizer: try KUBECONFIG first #1844

merged 1 commit into from
Mar 31, 2022

Conversation

tiraboschi
Copy link
Member

try to load KUBECONFIG first and eventaully
failback to incluster config only if the
first failed to mimic kubectl behaviour

See: kubernetes-client/python#1005

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 30, 2022
@tiraboschi
k8s-label-visualizer: try KUBECONFIG first
b4be26f 
try to load KUBECONFIG first and eventually
failback to incluster config only if the
first failed to mimic kubectl behaviour

See: kubernetes-client/python#1005

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

coveralls commented Mar 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2065386552

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.807%
Totals Coverage Status
Change from base Build 2064943674: 0.0%
Covered Lines: 3874
Relevant Lines: 4568
💛 - Coveralls

@machadovilaca
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machadovilaca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@kubevirt-bot kubevirt-bot merged commit 3940b2e into kubevirt:main Mar 31, 2022
@tiraboschi tiraboschi deleted the nightly_graphs branch April 1, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@sradco sradco Awaiting requested review from sradco

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiraboschi @coveralls @machadovilaca @kubevirt-bot