dataImportCronTemplates: Move default-instancetype to u1.medium #2397
Conversation
common-instancetypes v0.3.0 as deployed by SSP operator v0.18.1 renames the N neutral instance type class to U for universal ahead of new network related classes being introduced in a future release. This change moves the dataImportCronTemplates used by the SSP operator over to this new class. It also corrects a previous mistake, using the correct `u1.medium` name of the resource. A follow up change will provide some basic functional testing of this to ensure a mistake like this isn't able to merge in the future. This change is backwardly compatible, any previous users of the N instance type class either directly through their VirtualMachine definition or indirectly inferred through these default labels will not be impacted with their VirtualMachines continuing to use the original N instance type class. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/hold
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
the
dco-signoff: yes
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 5355511225
💛 - Coveralls |
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lyarwood: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
common-instancetypes v0.3.0 as deployed by SSP operator v0.18.1 renames the N neutral instance type class to U for universal ahead of new network related classes being introduced in a future release.
This change moves the dataImportCronTemplates used by the SSP operator over to this new class. It also corrects a previous mistake, using the correct
u1.mediumname of the resource. A follow up change will provide some basic functional testing of this to ensure a mistake like this isn't able to merge in the future.This change is backwardly compatible, any previous users of the N instance type class either directly through their VirtualMachine definition or indirectly inferred through these default labels will not be impacted with their VirtualMachines continuing to use the original N instance type class.
Reviewer Checklist
Jira Ticket:
Release note: