Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] Manually Bump CDI to v1.59.1 #3071

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[release-1.12] Manually Bump CDI to v1.59.1 #3071

merged 1 commit into from
Aug 26, 2024

Conversation

tiraboschi
Copy link
Member

What this PR does / why we need it:
This is a manual cherry-pick of #3059 for CDI v1.59.1.

Backporting:

  • smoke test: skip test_id:7679, as it fails

  • convert openshift TLSSecurityProfile to the CDI type

CDI new API redefined the TLSSecurityProfile type, originally from openshift. These two types are identicle, but each sub-type is redefined, and so each field requires castings.

  • build manifests with the new CDI version

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

NONE

Release note:

Bump CDI to v1.59.1

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 26, 2024
@tiraboschi tiraboschi mentioned this pull request Aug 26, 2024
Closed
@tiraboschi tiraboschi force-pushed the bump_CDI_v1.59.1_release-1.12_manual branch from 688be22 to 17926cb Compare August 26, 2024 10:50
@nunnatsa @tiraboschi
[release-1.12] Manually Bump CDI to v1.59.1
239e551 
* smoke test: skip test_id:7679, as it fails

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* convert openshift TLSSecurityProfile to the CDI type

CDI new API redefined the TLSSecurityProfile type, originally from
openshift. These two types are identicle, but each sub-type is
redefined, and so each field requires castings.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* build manifests with the new CDI version

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

This is a manual cherry-pick of kubevirt#3059
for CDI v1.59.1.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi tiraboschi force-pushed the bump_CDI_v1.59.1_release-1.12_manual branch from 17926cb to 239e551 Compare August 26, 2024 10:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link
Collaborator

coveralls commented Aug 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10558433529

Details

  • 11 of 18 (61.11%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 85.841%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/operands/cdi.go 11 18 61.11%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
Totals Coverage Status
Change from base Build 10403477393: -0.09%
Covered Lines: 5244
Relevant Lines: 6109
💛 - Coveralls

nunnatsa
nunnatsa approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@nunnatsa
Copy link
Collaborator

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 26, 2024

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws 239e551 link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-gcp 239e551 link true /test hco-e2e-operator-sdk-gcp
ci/prow/hco-e2e-upgrade-operator-sdk-aws 239e551 link true /test hco-e2e-upgrade-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2024

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2024

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws

In response to this:

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 26, 2024

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit a21737f into kubevirt:release-1.12 Aug 26, 2024
27 checks passed
@tiraboschi tiraboschi deleted the bump_CDI_v1.59.1_release-1.12_manual branch August 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiraboschi @coveralls @kubevirt-bot @nunnatsa @hco-bot