-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.12] Manually Bump CDI to v1.59.1 #3071
[release-1.12] Manually Bump CDI to v1.59.1 #3071
Conversation
688be22
to
17926cb
Compare
* smoke test: skip test_id:7679, as it fails Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com> * convert openshift TLSSecurityProfile to the CDI type CDI new API redefined the TLSSecurityProfile type, originally from openshift. These two types are identicle, but each sub-type is redefined, and so each field requires castings. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com> * build manifests with the new CDI version Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com> This is a manual cherry-pick of kubevirt#3059 for CDI v1.59.1. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
17926cb
to
239e551
Compare
Quality Gate passedIssues Measures |
Pull Request Test Coverage Report for Build 10558433529Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hco-e2e-upgrade-operator-sdk-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This is a manual cherry-pick of #3059 for CDI v1.59.1.
Backporting:
smoke test: skip test_id:7679, as it fails
convert openshift TLSSecurityProfile to the CDI type
CDI new API redefined the TLSSecurityProfile type, originally from openshift. These two types are identicle, but each sub-type is redefined, and so each field requires castings.
Reviewer Checklist
Jira Ticket:
Release note: