Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Fix the manual run of the bump bot, for specific branch #3123

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #3111

/assign nunnatsa

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 29, 2024
@tiraboschi
Copy link
Member

/rebase

If running the bump bot on a specific branch, the bot will still run for
all the release branches.

After this fix, only if running on main, it will run for all branches.

This change should be back ported to all the release branches in order
to take affect.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@hco-bot hco-bot force-pushed the cherry-pick-3111-to-release-1.11 branch from 65d9489 to 1682923 Compare October 4, 2024 07:48
Copy link

sonarcloud bot commented Oct 4, 2024

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11176088415

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 86.628%

Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
Totals Coverage Status
Change from base Build 11164827554: -0.02%
Covered Lines: 5416
Relevant Lines: 6252

💛 - Coveralls

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@kubevirt-bot kubevirt-bot merged commit 82a79ec into kubevirt:release-1.11 Oct 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants