Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: Audit * verbs #259

Merged
merged 1 commit into from
Sep 26, 2023
Merged

rbac: Audit * verbs #259

merged 1 commit into from
Sep 26, 2023

Conversation

jcanocan
Copy link
Contributor

@jcanocan jcanocan commented Sep 7, 2023

What this PR does / why we need it:
It replaces all * verbs by individual verbs required to run all intended operations.

It drops the usage of * verbs, replacing them by individual verbs strictly required by the test suite, i.e. unit tests and functional tests. The auditing process has been split in the next action items:

  • Deploying the operator in a CRC cluster and running the unit and function test.
  • Deploying the operator in a 3 masters and 3 workers nodes and running the unit and functional tests.

jira-ticket: CNV-24031

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=2223775

Special notes for your reviewer:

Release note:

Replace the `*` verbs by individual verbs

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
It drops the usage of `*` verbs replacing them by individual verbs
strictly required by the test suite, i.e. unit tests and functional
tests.

Signed-off-by: Javier Cano Cano <jcanocan@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Sep 7, 2023
@openshift-ci openshift-ci bot requested review from lyarwood and opokornyy September 7, 2023 13:21
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, jcanocan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@jcanocan
Copy link
Contributor Author

jcanocan commented Sep 7, 2023

/retest-required

7 similar comments
@0xFelix
Copy link
Member

0xFelix commented Sep 8, 2023

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@jcanocan
Copy link
Contributor Author

/retest-required

@ksimon1 ksimon1 merged commit 2fd756d into kubevirt:main Sep 26, 2023
@ksimon1
Copy link
Member

ksimon1 commented Oct 2, 2023

/cherry-pick release-v0.15

@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #264

In response to this:

/cherry-pick release-v0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ksimon1: new pull request created: #265

In response to this:

/cherry-pick release-v0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants