Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery category under blogs #474

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add gallery category under blogs #474

merged 1 commit into from
Feb 18, 2020

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Feb 3, 2020

What this PR does / why we need it:

Spinoff gallery section

Does this PR fix any issue? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Special notes for your reviewer:

preview at: https://deploy-preview-474--kubevirtio.netlify.com/gallery/

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/website Label for web site management/maintenance/... labels Feb 3, 2020
@iranzo
Copy link
Contributor Author

iranzo commented Feb 3, 2020

imagen

@iranzo
Copy link
Contributor Author

iranzo commented Feb 3, 2020

Related with #471 #450

@iranzo
Copy link
Contributor Author

iranzo commented Feb 4, 2020

/hold

Waiting for discussion on better design

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@iranzo
Copy link
Contributor Author

iranzo commented Feb 6, 2020

Ensure that new entries doesn't appear as blogposts only under gallery menu in the top page menus

@iranzo iranzo removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@ptrnull
Copy link
Contributor

ptrnull commented Feb 18, 2020

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ptrnull

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@kubevirt-bot kubevirt-bot merged commit e51e76f into kubevirt:source Feb 18, 2020
@iranzo iranzo deleted the gallery branch February 24, 2020 21:03
mazzystr pushed a commit to mazzystr/kubevirt.github.io that referenced this pull request Jun 4, 2020
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
mazzystr pushed a commit to mazzystr/kubevirt.github.io that referenced this pull request Jun 4, 2020
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/website Label for web site management/maintenance/... lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants