Revoke permission to GET secrets from virt-handler #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
danielBelenky
force-pushed
the
cloud-init-secrets
branch
from
e248342 to
36fe46b
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
danielBelenky
changed the title
|
/retest |
danielBelenky
force-pushed
the
cloud-init-secrets
branch
4 times, most recently
from
5bef12b to
6499120
Compare
In order to avoid giving virt-handler permission to GET all secrets across all namespaces, virt-controller will now render an additional secret volume mount to virt-launcher's pod. This will allow the launcher to read the secret from the disk. Signed-off-by: Daniel Belenky <dbelenky@redhat.com>
danielBelenky
force-pushed
the
cloud-init-secrets
branch
from
6499120 to
acb94e9
Compare
|
/retest |
1 similar comment
|
/retest |
danielBelenky
force-pushed
the
cloud-init-secrets
branch
from
acb94e9 to
07b848d
Compare
|
/retest |
rmohr
requested changes
Feb 3, 2020
tests/vmi_lifecycle_test.go
Outdated
| @@ -312,9 +312,27 @@ var _ = Describe("[rfe_id:273][crit:high][vendor:cnv-qe@redhat.com][level:compon | |||
| ) | |||
| }) | |||
|
|
|||
| Context("with user-data", func() { | |||
| FContext("with user-data", func() { | |||
added 2 commits
February 3, 2020 16:55
Instead of resolving the data directly from a secret, resolve the data from a secret volume mount. This is done to eventually take from virt-handler the capability to GET secrets across the cluster. Signed-off-by: Daniel Belenky <dbelenky@redhat.com>
virt-handler had to GET secrets across the cluster to inject cloud-init user data. Now, this process is done by reading the secret directly from the disk using a proper volume mount. since virt-handler still need access to secrets in the deployment namespace, this commit grants virt-handler the ability to get secrets in the deployment namespace. Signed-off-by: Daniel Belenky <dbelenky@redhat.com>
danielBelenky
force-pushed
the
cloud-init-secrets
branch
from
07b848d to
54e4a7c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
rmohr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid giving virt-handler permission to GET all secrets
across all namespaces, virt-controller will now renders an additional
secret volume mount to virt-launcher's pod. This allows virt-launcher
to read the secret directly from the disk instead of having virt-launcher
to GET it.
Signed-off-by: Daniel Belenky dbelenky@redhat.com
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2967
Special notes for your reviewer:
You don't see any functional test changes in this PR because those already exists from the previous implementation :)
Unit tests were adjusted to the new implementation...
Release note: