Run unit tests

[aerosouund]

What this PR does / why we need it:

With moving bash opts to golang, unit tests were introduced for every opt. But they aren't being run as a part of any CI process
This PR fixes all broken tests and changes the make test command of the gocli to run all tests in the project

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aerosouund]

cc: @xpivarc @dhiller @brianmcarey

[brianmcarey]

Which CI job will these tests be run in?

[aerosouund]

@brianmcarey
Test provision manager
Its what runs the make test command

[brianmcarey]

@brianmcarey Test provision manager Its what runs the make test command

Ok maybe we should update the job name to match the more generic nature of what is being run.

[dhiller]

@brianmcarey Test provision manager Its what runs the make test command

Ok maybe we should update the job name to match the more generic nature of what is being run.

Good point - however a separate task from this PR, no?

Suggestion: how about changing make all to include test target, since check-gocli calls it anyway 1? Then we could get rid of the other presubmit job?

[aerosouund]

Ok maybe we should update the job name to match the more generic nature of what is being run.

Yes, but where should this change take place ?
I'm not aware of how you can change stuff in prow (job configs, names.. etc)

[dhiller]

Ok maybe we should update the job name to match the more generic nature of what is being run.

Yes, but where should this change take place ? I'm not aware of how you can change stuff in prow (job configs, names.. etc)

it's inside project-infra folder github/ci/prow-deploy/files/jobs - there's the job definitions (see above link for the definition of check-gocli)

[dhiller]

@brianmcarey Test provision manager Its what runs the make test command

Ok maybe we should update the job name to match the more generic nature of what is being run.

Good point - however a separate task from this PR, no?

Suggestion: how about changing make all to include test target, since check-gocli calls it anyway 1? Then we could get rid of the other presubmit job?

@brianmcarey WDYT? ^^

[brianmcarey]

@brianmcarey Test provision manager Its what runs the make test command

Ok maybe we should update the job name to match the more generic nature of what is being run.

Good point - however a separate task from this PR, no?
Suggestion: how about changing make all to include test target, since check-gocli calls it anyway 1? Then we could get rid of the other presubmit job?

@brianmcarey WDYT? ^^

Sounds good to me - the lane should also be set to always run and be required too.

[aerosouund]

@brianmcarey @dhiller
will do