Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coordination version #160

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Update coordination version #160

merged 3 commits into from
Jun 18, 2021

Conversation

slintes
Copy link
Contributor

@slintes slintes commented Jun 18, 2021 •
edited
Loading

Use coordination API version v1, v1beta1 is deprecated

According to [1], there is no need for migration of existing lease
resources: "All existing persisted objects are accessible via the
new API"

Add version 0.9.1 manifests

[1] https://kubernetes.io/docs/reference/using-api/

Update coordination API version to v1, v1beta1 is deprecated

slintes added 2 commits June 18, 2021 09:41
@slintes
Use coordination API version v1, v1beta1 is deprecated
c405a43 
According to [1], there is no need for migration of existing lease
resources: "All existing persisted objects are accessible via the
new API"

[1] https://kubernetes.io/docs/reference/using-api/
  deprecation-guide/#lease-v122

Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@slintes
Add version 0.9.1
4518113 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from slintes after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested review from ksimon1 and yanirq June 18, 2021 07:44
@slintes
Copy link
Contributor Author

slintes commented Jun 18, 2021

/cherry-pick release-0.9

@kubevirt-bot
Copy link
Contributor

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added size/L release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2021
@slintes
Copy link
Contributor Author

slintes commented Jun 18, 2021

/retest

@slintes
Get rid of docker hub for go builder image
d815bb6 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
56.9% 56.9% Duplication

@slintes slintes merged commit 431d98d into kubevirt:master Jun 18, 2021
@kubevirt-bot
Copy link
Contributor

@slintes: #160 failed to apply on top of branch "release-0.9":

Applying: Add version 0.9.1
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
Patch failed at 0002 Add version 0.9.1

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slintes slintes deleted the update-coordination-version branch June 18, 2021 09:40
@slintes slintes mentioned this pull request Jun 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@yanirq yanirq Awaiting requested review from yanirq

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slintes @kubevirt-bot