Cleanup

- Pin image id - Remove unnecessary build steps - Add reasonable title attribute to html report files
kubevirt · Aug 22, 2019 · 0619fa2 · 0619fa2
1 parent 3f0df9b
commit 0619fa2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 18 deletions.
diff --git a/github/ci/prow/files/jobs/kubevirt/kubevirt-periodics.yaml b/github/ci/prow/files/jobs/kubevirt/kubevirt-periodics.yaml
@@ -7,7 +7,7 @@ periodics:
       type: vm
       zone: ci
     containers:
-    - image: index.docker.io/kubevirtci/flakefinder:latest
+    - image: index.docker.io/kubevirtci/flakefinder@sha256:491cb61028bd5fcb3ae5ae3e79497f7cf3b4d4e68b70b7471cdc7359a3123e86
       env:
       - name: GOOGLE_APPLICATION_CREDENTIALS
         value: /etc/gcs/service-account.json

diff --git a/robots/flakefinder/BUILD.bazel b/robots/flakefinder/BUILD.bazel
@@ -21,28 +21,13 @@ go_library(
     ],
 )
 
-go_binary(
-    name = "flakefinder",
-    embed = [":go_default_library"],
-    visibility = ["//visibility:public"],
-)
-
 load("@io_bazel_rules_docker//go:image.bzl", "go_image")
 
 go_image(
     name = "app",
     embed = [":go_default_library"],
 )
 
-load("@io_bazel_rules_docker//docker:docker.bzl", "docker_bundle")
-
-docker_bundle(
-    name = "bundle",
-    images = {
-        "kubevirtci/flakefinder:latest": ":app",
-    },
-)
-
 load("@io_bazel_rules_docker//container:container.bzl", "container_push")
 
 container_push(

diff --git a/robots/flakefinder/index.go b/robots/flakefinder/index.go
@@ -17,7 +17,7 @@ const indexTpl = `
 <html lang="en">
 <head>
     <meta charset="UTF-8">
-    <title>Title</title>
+    <title>kubevirt.io - flakefinder reports</title>
 	<style>
 		table, th, td {
 		  border: 1px solid black;
@@ -27,7 +27,7 @@ const indexTpl = `
 <body>
 	<table>
 		<tr>
-			<th>FlakeFinder reports</th>
+			<th>flakefinder reports</th>
 		</tr>
 {{ range $reportFile := $.Reports }}
 		<tr>

diff --git a/robots/flakefinder/report.go b/robots/flakefinder/report.go
@@ -17,6 +17,7 @@ const tpl = `
 <!DOCTYPE html>
 <html>
 <head>
+<title>kubevirt.io - flakefinder report</title>
 <meta charset="UTF-8">
 <style>
 table, th, td {