Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced wget with curl in dockerfile #348

Merged
merged 1 commit into from
May 10, 2022
Merged

replaced wget with curl in dockerfile #348

merged 1 commit into from
May 10, 2022

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented May 6, 2022 •
edited
Loading

What this PR does / why we need it:
replaced wget with curl in dockerfile
removed gzip package, run microdnf update before installing packages

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 6, 2022
@kubevirt-bot kubevirt-bot requested review from borod108 and lyarwood May 6, 2022 07:30
@ksimon1
replaced wget with curl in dockerfile
7a99d70 
run microdnf update

Signed-off-by: Karel Šimon <ksimon@redhat.com>
@ksimon1 ksimon1 force-pushed the improve-dockerfile branch from de8ae3c to 7a99d70 Compare May 6, 2022 07:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ksimon1
Copy link
Member Author

ksimon1 commented May 9, 2022

/retest

@akrejcir
Copy link
Collaborator

akrejcir commented May 9, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@ksimon1
Copy link
Member Author

ksimon1 commented May 9, 2022

/retest

1 similar comment
@akrejcir
Copy link
Collaborator

akrejcir commented May 9, 2022

/retest

@ksimon1
Copy link
Member Author

ksimon1 commented May 9, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@ksimon1
Copy link
Member Author

ksimon1 commented May 10, 2022

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2022
@kubevirt-bot kubevirt-bot merged commit 7875a85 into kubevirt:master May 10, 2022
@akrejcir akrejcir mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 Awaiting requested review from borod108

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksimon1 @akrejcir @kubevirt-bot