Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] Fix env variables #591

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[release-v0.18] Fix env variables #591

merged 1 commit into from
Jun 26, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jun 26, 2023 •
edited
Loading

What this PR does / why we need it:
fix: add VIRTIO_IMG env variable to manager manifest
remove VIRT_LAUNCHER env variable, which is not used anywhere.

VIRTIO_IMG is needed for tekton pipelines

PR to main will follow after this PR
/cc @akrejcir
Release note:

NONE

@ksimon1
fix: add VIRTIO_IMG env variable to manager manifest
1766e2d 
remove VIRT_LAUNCHER env variable, which is not used anywhere.

Signed-off-by: Karel Šimon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jun 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

I see the the VIRTIO_IMG is used by the newly added tekton-pipelines operand.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@kubevirt-bot kubevirt-bot merged commit 086ccbf into kubevirt:release-v0.18 Jun 26, 2023
@ksimon1
Copy link
Member Author

ksimon1 commented Jun 26, 2023

/cherrypick main

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 26, 2023
Merged
@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #596

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksimon1 @akrejcir @kubevirt-bot