Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] feat: add deploy VM console proxy feature gate #633

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[release-v0.18] feat: add deploy VM console proxy feature gate #633

merged 1 commit into from
Jul 24, 2023

Conversation

codingben
Copy link
Member

What this PR does / why we need it:

Add a new Feature Gate to deploy VM console
proxy resources.

Jira-Url: https://issues.redhat.com/browse/CNV-30283

Note: This PR is the cherry pick of #609 manually since automation didn't work because of conflicts.

Release note:

Add deployVmConsoleProxy feature gate

@codingben
feat: add deploy VM console proxy feature gate
1e0fe81 
Add a new Feature Gate to deploy VM console
proxy resources.

Jira-Url: https://issues.redhat.com/browse/CNV-30283
Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Jul 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codingben codingben mentioned this pull request Jul 23, 2023
Merged
@codingben
Copy link
Member Author

Hi @akrejcir @0xFelix, CI passed, can you please merge it? we need a new release to continue working on HCO PR [1].

[1] kubevirt/hyperconverged-cluster-operator#2440

0xFelix
0xFelix approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@kubevirt-bot kubevirt-bot merged commit 3505581 into kubevirt:release-v0.18 Jul 24, 2023
3 checks passed
@akrejcir akrejcir changed the title feat: add deploy VM console proxy feature gate [release-v0.18] feat: add deploy VM console proxy feature gate Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codingben @kubevirt-bot @0xFelix