Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rework add reviewer workflow #651

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat: Rework add reviewer workflow #651

merged 1 commit into from
Aug 10, 2023

Conversation

opokornyy
Copy link
Contributor

What this PR does / why we need it:

This PR reworks the add reviewer workflow to simply add a '/cc user' comment and let Prow handle the rest.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 10, 2023
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS labels Aug 10, 2023
@opokornyy
feat: Rework add reviewer workflow
f52838e 
This commit reworks the add reviewer workflow to
simply add a '/cc user' comment and let Prow handle
the rest.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy force-pushed the rework-add-reviewer branch from c78e92e to f52838e Compare August 10, 2023 09:44
@kubevirt-bot kubevirt-bot added size/S and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS labels Aug 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@opokornyy
Copy link
Contributor Author

/cc @0xFelix @ksimon1

@ksimon1
Copy link
Member

ksimon1 commented Aug 10, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
0xFelix
0xFelix approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@kubevirt-bot kubevirt-bot merged commit fc2962f into kubevirt:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@codingben codingben Awaiting requested review from codingben

@jcanocan jcanocan Awaiting requested review from jcanocan

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opokornyy @ksimon1 @kubevirt-bot @0xFelix