Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] refactor(CNV-31248): remove namespace annotation #678

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[release-v0.18] refactor(CNV-31248): remove namespace annotation #678

merged 1 commit into from
Sep 1, 2023

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Sep 1, 2023

This is a backport of: #634

Release note:

Remove vm-console-proxy-namespace annotation

@codingben @akrejcir
refactor(CNV-31248): remove namespace annotation
4f0aaa0 
Remove vm-console-proxy-namespace annotation that
is no longer relevant since a new released VM
console proxy is no longer require namespace
to operate, by default it was kubevirt as it
required an access to virt-handler (and also
virt-handler certificates).

Jira-Url: https://issues.redhat.com/browse/CNV-31248
Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 1, 2023
@akrejcir
Copy link
Collaborator Author

akrejcir commented Sep 1, 2023

/cc @lyarwood @ksimon1

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lyarwood
Copy link
Member

lyarwood commented Sep 1, 2023

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@kubevirt-bot kubevirt-bot merged commit a6ee5f8 into kubevirt:release-v0.18 Sep 1, 2023
3 checks passed
@akrejcir akrejcir deleted the remove-proxy-namespace-0.18 branch September 1, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@lyarwood lyarwood

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @lyarwood @kubevirt-bot @codingben