Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add script to sync common-instancetypes #900

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

This change copies logic previously held in the periodic-update-common-instancetypes-bundles job into the SSP repo. This will allow us to remove the duplicate logic from the job definition in the future, simplifying it greatly.

Which issue(s) this PR fixes:

Partial Fix# kubevirt/common-instancetypes#162

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 27, 2024
@lyarwood lyarwood force-pushed the add-sync-common-instancetypes branch from e46ca25 to 19ffc55 Compare February 27, 2024 12:32
@lyarwood
Copy link
Member Author

/cc 0xFelix

@kubevirt-bot kubevirt-bot requested a review from 0xFelix February 27, 2024 12:48
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2024
@lyarwood
Copy link
Member Author

lyarwood commented Feb 27, 2024

/hold

Just want to add the same ?per_page=100 param as kubevirt/kubevirt#11368

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
This change copies logic previously held in the
periodic-update-common-instancetypes-bundles job into the SSP repo. This
will allow us to remove the duplicate logic from the job definition in
the future, simplifying it greatly.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the add-sync-common-instancetypes branch from 19ffc55 to 2dde7df Compare February 27, 2024 13:24
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@lyarwood
Copy link
Member Author

/hold cancel

@0xFelix can you take another look?

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024

function latest_version() {
if [[ $target_branch == "main" ]]; then
curl --fail -s "https://api.github.com/repos/kubevirt/common-instancetypes/releases/latest" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop use of --fail, likely has no effect here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubevirt/kubevirt/blob/0ca03aa05ccab5fefc6bfe7b474e5e05e18929a4/hack/bump-common-instancetypes.sh#L8-L14 - That's copied from your script in kubevirt/kubevirt and I think it does make sense here for the API calls.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep it then

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm


function latest_version() {
if [[ $target_branch == "main" ]]; then
curl --fail -s "https://api.github.com/repos/kubevirt/common-instancetypes/releases/latest" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep it then

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 5982bea into kubevirt:main Mar 4, 2024
12 checks passed
@lyarwood
Copy link
Member Author

lyarwood commented Mar 4, 2024

/cherry-pick release-v0.19

@kubevirt-bot
Copy link
Contributor

@lyarwood: new pull request created: #908

In response to this:

/cherry-pick release-v0.19
/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
Copy link
Member Author

lyarwood commented Mar 4, 2024

/cherry-pick release-v0.18

@kubevirt-bot
Copy link
Contributor

@lyarwood: new pull request created: #909

In response to this:

/cherry-pick release-v0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants