chore: Update vm-console-proxy to v0.5.0 #916
Conversation
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
kubevirt-bot
added
release-note
| @@ -142,5 +144,10 @@ func validateBundle(bundle *Bundle) error { | |||
| if len(missingFields) > 0 { | |||
| return fmt.Errorf("bundle is missing these objects: %v", missingFields) | |||
| } | |||
|
|
|||
| if len(bundle.ClusterRoles) != 2 { | |||
There was a problem hiding this comment.
Do we need to hardcode this check here?
There was a problem hiding this comment.
No. I wanted to be explicit, that there should be 2 roles.
I will make the code more generic.
There was a problem hiding this comment.
I've just removed the condition. Making the code more generic is maybe a task for a future PR.
akrejcir
force-pushed
the
update-vm-console-proxy
branch
from
cc00fbe to
6044bd7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
The latest vm-console-proxy contains a new cluster role. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
update-vm-console-proxy
branch
from
6044bd7 to
ef0be76
Compare
|
|
/cc @jcanocan |
|
Great work @akrejcir ! |
What this PR does / why we need it:
Updated
vm-console-proxyto versionv0.5.0, and changed code to support multipleClusterRoles.Release note: