Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.19] fix: Increase reconcile metric only if SSP CR was not changed #959

Closed
wants to merge 1 commit into from
Closed

[release-v0.19] fix: Increase reconcile metric only if SSP CR was not changed #959

wants to merge 1 commit into from

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #950

/assign akrejcir

None

@akrejcir
fix: Increase reconcile metric only if SSP CR was not changed
44d86e3 
The metric "kubevirt_ssp_common_templates_restored_total" should
be increased if user changes a template and the operator restores
it back to what it should be.

If the SSP CR is changed, for example one of the labels
that are propagated to the templates are changed,
then the reconciliation should not increase the metric.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 15, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 15, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@akrejcir
Copy link
Collaborator

/cc @0xFelix @jcanocan

@jcanocan
Copy link
Contributor

Looks like the build failed:
Error: internal/operands/common-templates/reconcile_test.go:350:18: undefined: metrics (typecheck)

0xFelix
0xFelix reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we need a manual backport or 393170b needs to be backported first

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 15, 2024

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 44d86e3 link true /test images
ci/prow/e2e-functests 44d86e3 link true /test e2e-functests
ci/prow/e2e-single-node-functests 44d86e3 link true /test e2e-single-node-functests
ci/prow/e2e-upgrade-functests 44d86e3 link true /test e2e-upgrade-functests
ci/prow/unittests 44d86e3 link true /test unittests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akrejcir
Copy link
Collaborator

I will post a manual backport.

/close

@kubevirt-bot
Copy link
Contributor Author

@akrejcir: Closed this PR.

In response to this:

I will post a manual backport.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@codingben codingben Awaiting requested review from codingben

@opokornyy opokornyy Awaiting requested review from opokornyy

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@akrejcir akrejcir

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubevirt-bot @akrejcir @jcanocan @0xFelix