fix: do not check if affinity is empty.

The policy server reconciler check if the policy server spec has a non
empty affinity. If that's the case, it set the affinity in the policy
server deployment. This allow users to set the affinity manually in the
deployment. This should not be allowed. The policy server CRDS should be
the interface to configure the affinity. Therefore, that check is
removed and the affinity from the policy server spec is always set in
the deployment.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>

internal/controller/policyserver_controller_deployment.go

@@ -169,6 +169,7 @@ func (r *PolicyServerReconciler) updatePolicyServerDeployment(policyServer *poli
 				Containers:         []corev1.Container{admissionContainer},
 				ServiceAccountName: policyServer.Spec.ServiceAccountName,
 				Tolerations:        policyServer.Spec.Tolerations,
+				Affinity:           &policyServer.Spec.Affinity,
 				Volumes: []corev1.Volume{
 					{
 						Name: policyStoreVolume,
@@ -296,10 +297,6 @@ func (r *PolicyServerReconciler) adaptDeploymentSettingsForPolicyServer(policySe
 			},
 		)
 	}
-
-	if emptyAffinity := (corev1.Affinity{}); policyServer.Spec.Affinity != emptyAffinity {
-		policyServerDeployment.Spec.Template.Spec.Affinity = &policyServer.Spec.Affinity
-	}
 }
 
 func envVarsContainVariable(envVars []corev1.EnvVar, envVarName string) int {

internal/controller/policyserver_controller_test.go

@@ -366,7 +366,11 @@ var _ = Describe("PolicyServer controller", func() {
 					"FSGroupChangePolicy": BeNil(),
 					"SeccompProfile":      BeNil(),
 				})),
-				"Affinity": BeNil(),
+				"Affinity": PointTo(MatchAllFields(Fields{
+					"NodeAffinity":    BeNil(),
+					"PodAffinity":     BeNil(),
+					"PodAntiAffinity": BeNil(),
+				})),
 			}))
 		})