deps: Update to controller-runtime v0.14.6, ginkgo/v2 #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sigs.k8s.io/controller-runtime/pkg/envtest/printer` is not present in controller-runtime >= 1.14.1, nor ginkgo v1. Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Pull `sigs.k8s.io/controller-runtime/pkg/log/zap@v0.14.6` as part of it. ``` go get sigs.k8s.io/controller-runtime@latest go get sigs.k8s.io/controller-runtime/pkg/log/zap@v0.14.6 ``` Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
go get -u github.com/go-logr/logr go.opentelemetry.io/otel go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc go.opentelemetry.io/otel/metric go.opentelemetry.io/otel/sdk/metric go mod tidy Can't bump to client-go v0.27.1: operator-framework/operator-sdk#6396 Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
|
This needs to get tagged to be consumed by audit-scanner. |
flavio
reviewed
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump controller-runtime to get rid of ginkgo v1.
Relates to kubewarden/audit-scanner#24
Audit scanner needs ginkgo/v2.
Bump open-telemetry.
Don't bump client-go to 0.27.0 yet: operator-framework/operator-sdk#6396
Test
make test.Additional Information
Supercedes #306.
Tradeoff
Potential improvement