feat: add limits and requests to PolicyServer

pkg/apis/policies/v1/policyserver_webhook.go

@@ -18,10 +18,13 @@ package v1
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/kubewarden/kubewarden-controller/internal/pkg/constants"
 	"github.com/kubewarden/kubewarden-controller/internal/pkg/policyserver"
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/apimachinery/pkg/runtime"
 	validationutils "k8s.io/apimachinery/pkg/util/validation"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -56,6 +59,16 @@ func (ps *PolicyServer) Default() {
 	if ps.ObjectMeta.DeletionTimestamp == nil {
 		controllerutil.AddFinalizer(ps, constants.KubewardenFinalizer)
 	}
+
+	// Default the requests to the limits if not set
+	for limitName, limitQuantity := range ps.Spec.Limits {
+		if _, found := ps.Spec.Requests[limitName]; !found {
+			if ps.Spec.Requests == nil {
+				ps.Spec.Requests = make(corev1.ResourceList)
+			}
+			ps.Spec.Requests[limitName] = limitQuantity
+		}
+	}
 }
 
 // +kubebuilder:webhook:path=/validate-policies-kubewarden-io-v1-policyserver,mutating=false,failurePolicy=fail,sideEffects=None,groups=policies.kubewarden.io,resources=policyservers,verbs=create;update,versions=v1,name=vpolicyserver.kb.io,admissionReviewVersions=v1
@@ -86,7 +99,12 @@ func (v *policyServerValidator) validate(ctx context.Context, obj runtime.Object
 
 	// Kubernetes does not allow to set both MinAvailable and MaxUnavailable at the same time
 	if policyServer.Spec.MinAvailable != nil && policyServer.Spec.MaxUnavailable != nil {
-		return fmt.Errorf("minAvailable and maxUnavailable cannot be both set")
+		return errors.New("minAvailable and maxUnavailable cannot be both set")
+	}
+
+	err := validateLimitsAndRequests(policyServer.Spec.Limits, policyServer.Spec.Requests)
+	if err != nil {
+		return err
 	}
 
 	return nil
@@ -103,3 +121,31 @@ func (v *policyServerValidator) ValidateUpdate(ctx context.Context, _, obj runti
 func (v *policyServerValidator) ValidateDelete(_ context.Context, _ runtime.Object) (admission.Warnings, error) {
 	return nil, nil
 }
+
+func validateLimitsAndRequests(limits, requests corev1.ResourceList) error {
+	if requests == nil || limits == nil {
+		return nil
+	}
+
+	for limitName, limitQuantity := range limits {
+		if limitQuantity.Cmp(resource.Quantity{}) < 0 {
+			return fmt.Errorf("%s limit must be greater than or equal to 0", limitName)
+		}
+	}
+
+	for requestName, requestQuantity := range requests {
+		if requestQuantity.Cmp(resource.Quantity{}) < 0 {
+			return fmt.Errorf("%s request must be greater than or equal to 0", requestName)
+		}
+
+		limitQuantity, ok := limits[requestName]
+		if !ok {
+			continue
+		}
+
+		if requestQuantity.Cmp(limitQuantity) > 0 {
+			return fmt.Errorf("request must be less than or equal to %s limit", requestName)
+		}
+	}
+	return nil
+}

pkg/apis/policies/v1/policyserver_webhook_test.go

@@ -16,14 +16,41 @@ package v1
 
 import (
 	"context"
+	"errors"
 	"testing"
 
+	"github.com/kubewarden/kubewarden-controller/internal/pkg/constants"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
 )
 
+func TestDefault(t *testing.T) {
+	policyServer := &PolicyServer{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: "policy-server",
+		},
+		Spec: PolicyServerSpec{
+			Limits: corev1.ResourceList{
+				"cpu":    resource.MustParse("1Gi"),
+				"memory": resource.MustParse("1Gi"),
+			},
+		},
+	}
+
+	policyServer.Default()
+
+	assert.Contains(t, policyServer.Finalizers, constants.KubewardenFinalizer)
+	assert.Equal(t, corev1.ResourceList{
+		"cpu":    resource.MustParse("1Gi"),
+		"memory": resource.MustParse("1Gi"),
+	}, policyServer.Spec.Requests)
+}
+
 func TestValidatePolicyServerName(t *testing.T) {
 	name := make([]byte, 64)
 	for i := range name {
@@ -68,3 +95,54 @@ func TestValidateMinAvailable(t *testing.T) {
 	err := policyServerValidator.validate(context.Background(), policyServer)
 	require.ErrorContains(t, err, "minAvailable and maxUnavailable cannot be both set")
 }
+
+func TestValidateLimitsAndRequests(t *testing.T) {
+	testCases := []struct {
+		Name        string
+		Limits      corev1.ResourceList
+		Requests    corev1.ResourceList
+		ExpectedErr error
+	}{
+		{
+			Name:        "valid",
+			Limits:      corev1.ResourceList{"cpu": resource.MustParse("1Gi")},
+			Requests:    corev1.ResourceList{"cpu": resource.MustParse("500Mi")},
+			ExpectedErr: nil,
+		},
+		{
+			Name:        "negative limit",
+			Limits:      corev1.ResourceList{"cpu": resource.MustParse("-1Gi")},
+			Requests:    corev1.ResourceList{"cpu": resource.MustParse("500Mi")},
+			ExpectedErr: errors.New("cpu limit must be greater than or equal to 0"),
+		},
+		{
+			Name:        "negative request",
+			Limits:      corev1.ResourceList{"cpu": resource.MustParse("1Gi")},
+			Requests:    corev1.ResourceList{"cpu": resource.MustParse("-500Mi")},
+			ExpectedErr: errors.New("cpu request must be greater than or equal to 0"),
+		},
+		{
+			Name:        "request greater than limit",
+			Limits:      corev1.ResourceList{"cpu": resource.MustParse("1Gi")},
+			Requests:    corev1.ResourceList{"cpu": resource.MustParse("2Gi")},
+			ExpectedErr: errors.New("request must be less than or equal to cpu limit"),
+		},
+	}
+
+	for _, test := range testCases {
+		t.Run(test.Name, func(t *testing.T) {
+			policyServer := &PolicyServer{
+				Spec: PolicyServerSpec{
+					Limits:   test.Limits,
+					Requests: test.Requests,
+				},
+			}
+			policyServerValidator := policyServerValidator{
+				k8sClient:            nil,
+				deploymentsNamespace: "default",
+			}
+			err := policyServerValidator.validate(context.Background(), policyServer)
+			assert.Equal(t, err, test.ExpectedErr)
+		})
+	}
+}