fix: allow kwctl to build using latest version of this crate #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `Serialize` and `Deserialize` traits have been removed from the `CallbackRequestType`. That was done because the `tokio::time::Instant` trait doesn't derive them. I initially though we didn't need these traits to be provided by this object. That proved true because I was working only on Policy Server, which doesn't require them. However, kwctl requires them to save and restore context aware sessions. This commit introduces custom serializer and deserializer functions for `tokio::time::Instant`, making possible to reintroduce the `Serialize` and `Deserialize` traits. This fixes the compilation of kwctl. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 45.24% 45.08% -0.16%
==========================================
Files 53 53
Lines 2871 2881 +10
==========================================
Hits 1299 1299
- Misses 1572 1582 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fabriziosestito
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
SerializeandDeserializetraits have been removed from theCallbackRequestType. That was done because thetokio::time::Instanttrait doesn't derive them.I initially though we didn't need these traits to be provided by this object. That proved true because I was working only on Policy Server, which doesn't require them.
However, kwctl requires them to save and restore context aware sessions.
This commit introduces custom serializer and deserializer functions for
tokio::time::Instant, making possible to reintroduce theSerializeandDeserializetraits. This fixes the compilation of kwctl.