fix: ensure consumers of policy-fetcher can compile #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under special circumstances, some code that makes uses of policy-fetcher does not compile. That happens when the consumer of policy-fetcher is created inside of a tokio task with `tokio::spawn()`. That happens because the private `url_fetcher` takes as a parameter something that implements the `PolicyFetcher` trait, but is not explicit about requiring also the `Send` attribute. The `Send` attribute is required by tokio to move the task between its worker threads. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
jvanz
approved these changes
Jul 17, 2024
|
thanks @jvanz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under special circumstances, some code that makes uses of policy-fetcher does not compile.
That happens when the consumer of policy-fetcher is created inside of a tokio task with
tokio::spawn().That happens because the private
url_fetchertakes as a parameter something that implements thePolicyFetchertrait, but is not explicit about requiring also theSendattribute. TheSendattribute is required by tokio to move the task between its worker threads.Once this is merged I'll tag a new patch release of the crate. This is required by the integration tests of
policy-serverto test the certificate reload.