Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set prerelease and latest flag properly. #702

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Mar 13, 2024

Description

The release.yml is not properly setting the release as prerelease or latest release because the field used to check if the tag is a prerelease was not populated. This commit fixes that using another field.

Fix kubewarden/kubewarden-controller#657

@jvanz jvanz self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.33%. Comparing base (000e8ca) to head (4b23144).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #702       +/-   ##
===========================================
- Coverage   51.57%   31.33%   -20.24%     
===========================================
  Files          16       15        -1     
  Lines         731      702       -29     
===========================================
- Hits          377      220      -157     
- Misses        354      482      +128     
Flag Coverage Δ
integration-tests ?
unit-tests 31.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The release.yml is not properly setting the release as prerelease or
latest release because the field used to check if the tag is a
prerelease was not populated. This commit fixes that using another
field.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
@jvanz jvanz force-pushed the prerelease_latest_flag branch from fde64b9 to 4b23144 Compare March 13, 2024 21:19
@jvanz jvanz marked this pull request as ready for review March 13, 2024 21:46
@jvanz jvanz requested a review from a team as a code owner March 13, 2024 21:46
@viccuad viccuad merged commit 570f21f into kubewarden:main Mar 14, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI is not properly tagging releases as latest
2 participants