fix policies yml parsing #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seeems to be issues with the usage of the `deny_unknown_fields` and untagged enumerations. serde ends up confused and complains about perfectly valid files. See serde-rs/serde#1600 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
The contents of the file were based on the initial RFC format, which was then changed. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
viccuad
approved these changes
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
=======================================
Coverage 58.45% 58.45%
=======================================
Files 17 17
Lines 994 994
=======================================
Hits 581 581
Misses 413 413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
approved these changes
Jul 17, 2024
fabriziosestito
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the failures reported by our CI system.
They were caused by two changes done to the
policies.ymlfile parsing:deny_unknown_fieldswith untaggedEnumis affected by a bug inside of theserdelibrary. This is a known issuepolicies.yml.examplefile had invalid contents