-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: support dynamic config for shared_cores overlaping reclaimed_cores
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
- Loading branch information
1 parent
29a7b82
commit 4391efa
Showing
7 changed files
with
95 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
cmd/katalyst-agent/app/options/dynamic/adminqos/advisor/cpu_region.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| Copyright 2022 The Katalyst Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package advisor | ||
|
|
||
| import ( | ||
| cliflag "k8s.io/component-base/cli/flag" | ||
|
|
||
| "github.com/kubewharf/katalyst-core/pkg/config/agent/dynamic/adminqos/advisor" | ||
| ) | ||
|
|
||
| type CPURegionOptions struct { | ||
| AllowSharedCoresOverlapReclaimedCores bool | ||
| } | ||
|
|
||
| func NewCPURegionOptions() *CPURegionOptions { | ||
| return &CPURegionOptions{ | ||
| AllowSharedCoresOverlapReclaimedCores: false, | ||
| } | ||
| } | ||
|
|
||
| // AddFlags parses the flags to CPURegionOptions | ||
| func (o *CPURegionOptions) AddFlags(fss *cliflag.NamedFlagSets) { | ||
| fs := fss.FlagSet("cpu-region") | ||
| // | ||
| fs.BoolVar(&o.AllowSharedCoresOverlapReclaimedCores, "cpu-region-allow-shared-cores-overlap-reclaimed-cores", o.AllowSharedCoresOverlapReclaimedCores, | ||
| "set true to allow shared_cores overlap reclaimed_cores") | ||
| } | ||
|
|
||
| func (o *CPURegionOptions) ApplyTo(c *advisor.CPURegionConfiguration) error { | ||
| c.AllowSharedCoresOverlapReclaimedCores = o.AllowSharedCoresOverlapReclaimedCores | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| Copyright 2022 The Katalyst Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package advisor | ||
|
|
||
| import "github.com/kubewharf/katalyst-core/pkg/config/agent/dynamic/crd" | ||
|
|
||
| type CPURegionConfiguration struct { | ||
| AllowSharedCoresOverlapReclaimedCores bool | ||
| } | ||
|
|
||
| func NewCPURegionConfiguration() *CPURegionConfiguration { | ||
| return &CPURegionConfiguration{ | ||
| AllowSharedCoresOverlapReclaimedCores: false, | ||
| } | ||
| } | ||
|
|
||
| func (c *CPURegionConfiguration) ApplyConfiguration(conf *crd.DynamicConfigCRD) { | ||
| if aqc := conf.AdminQoSConfiguration; aqc != nil && | ||
| aqc.Spec.Config.AdvisorConfig != nil && | ||
| aqc.Spec.Config.AdvisorConfig.CPUAdvisorConfig != nil && | ||
| aqc.Spec.Config.AdvisorConfig.CPUAdvisorConfig.AllowSharedCoresOverlapReclaimedCores != nil { | ||
| c.AllowSharedCoresOverlapReclaimedCores = *aqc.Spec.Config.AdvisorConfig.CPUAdvisorConfig.AllowSharedCoresOverlapReclaimedCores | ||
| } | ||
| } |