Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): add golangci-lint to CI pipeline and fix lint issues #10

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

caohe
Copy link
Member

@caohe caohe commented Apr 6, 2023

What type of PR is this?

Chore

What this PR does / why we need it:

  • enable lint check and modify its config.
  • fix some weird gofmt issues

@caohe caohe force-pushed the lint branch 21 times, most recently from 28621c9 to 04696c6 Compare April 6, 2023 12:05
@caohe caohe requested a review from waynepeking348 April 6, 2023 12:15
@caohe caohe added the chore label Apr 6, 2023
@caohe caohe added this to the v0.2 milestone Apr 6, 2023
@caohe caohe force-pushed the lint branch 2 times, most recently from 74cd52c to 1051775 Compare April 7, 2023 07:52
Signed-off-by: caohe <caohe9603@gmail.com>
@caohe caohe changed the title chore(*): modify lint config chore(*): add golangci-lint to CI pipeline and fix lint issues Apr 11, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023

CLA assistant check
All committers have signed the CLA.

@waynepeking348 waynepeking348 force-pushed the lint branch 2 times, most recently from 1b8a79f to ad413c9 Compare April 11, 2023 10:05
@waynepeking348 waynepeking348 merged commit d23ce94 into kubewharf:main Apr 11, 2023
@caohe caohe deleted the lint branch April 11, 2023 11:18
@caohe caohe restored the lint branch April 11, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants