Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spd indicator plugin init function support spd workload informer #103

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

spd indicator plugin init function support use spd workload informer.

@luomingmeng luomingmeng added chore workflow/need-review review: test succeeded, need to review labels Jun 12, 2023
@luomingmeng luomingmeng added this to the v0.2 milestone Jun 12, 2023
@luomingmeng luomingmeng self-assigned this Jun 12, 2023
@luomingmeng luomingmeng force-pushed the dev/spd_indicator_plugin_support_workload_gvr_map branch from 41a7599 to feae2cf Compare June 12, 2023 11:57
@luomingmeng luomingmeng marked this pull request as ready for review June 12, 2023 12:04
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 52.68% and project coverage change: +1.69 🎉

Comparison is base (21d86d9) 51.30% compared to head (feae2cf) 52.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   51.30%   52.99%   +1.69%     
==========================================
  Files         318      366      +48     
  Lines       32418    34712    +2294     
==========================================
+ Hits        16632    18397    +1765     
- Misses      13840    14175     +335     
- Partials     1946     2140     +194     
Flag Coverage Δ
unittest 52.99% <52.68%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
...gent/app/options/dynamic/adminqos/adminqos_base.go 54.54% <ø> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.73% <ø> (+5.38%) ⬆️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <0.00%> (ø)
...ourcemanager/fetcher/kubelet/topology/interface.go 0.00% <0.00%> (ø)
...ger/fetcher/kubelet/topology/podresourcesserver.go 55.35% <ø> (-5.71%) ⬇️
.../agent/resourcemanager/reporter/cnr/cnrreporter.go 62.20% <ø> (-2.06%) ⬇️
... and 170 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 12, 2023
@waynepeking348 waynepeking348 merged commit 660b589 into kubewharf:main Jun 12, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants