implement rama policy framework with pid controller #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun-yuliang
added
enhancement
sun-yuliang
changed the title
sun-yuliang
force-pushed
the
syl/implement-rama-policy
branch
from
cd6d8dd to
9ecb9a7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 51.30% 51.52% +0.22%
==========================================
Files 318 377 +59
Lines 32418 36288 +3870
==========================================
+ Hits 16632 18698 +2066
- Misses 13840 15438 +1598
- Partials 1946 2152 +206
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sun-yuliang
force-pushed
the
syl/implement-rama-policy
branch
5 times, most recently
from
aea7ddc to
d5d2c54
Compare
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/region/region_dedicated_numa_exclusive.go
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/region/region_dedicated_numa_exclusive.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/region/provisionpolicy/policy_rama.go
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/region/provisionpolicy/policy_rama.go
Show resolved
Hide resolved
|
there still exists some comments, we need to discuss before this pr can be merged |
| @@ -17,16 +17,14 @@ limitations under the License. | |||
| package headroompolicy | |||
There was a problem hiding this comment.
if this policy is deprecated, which one should we use? will there be a corresponding rama headroom policy?
There was a problem hiding this comment.
There may be a policy based on machine learning to estimate NUMA headroom for dedicated numa exclusive region in the future.
sun-yuliang
force-pushed
the
syl/implement-rama-policy
branch
2 times, most recently
from
6d9df75 to
7d1ace5
Compare
sun-yuliang
changed the title
sun-yuliang
added
workflow/merge-ready
sun-yuliang
force-pushed
the
syl/implement-rama-policy
branch
from
7d1ace5 to
80aa3fd
Compare
sun-yuliang
force-pushed
the
syl/implement-rama-policy
branch
from
80aa3fd to
e4d334a
Compare
waynepeking348
approved these changes
Jun 19, 2023
sun-yuliang
added
workflow/merge-ready
cheney-lin
approved these changes
Jun 19, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Implement the framework of a fine tuned policy "rama" for dedicated numa exclusive region
Which issue(s) this PR fixes:
Special notes for your reviewer: