Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): network plugin deal with sidecars #114

Merged

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Jun 20, 2023

What type of PR is this?

feat(qrm): network plugin deal with sidecars

@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Jun 20, 2023
@csfldf csfldf requested review from waynepeking348 and caohe June 20, 2023 10:55
@csfldf csfldf self-assigned this Jun 20, 2023
waynepeking348
waynepeking348 previously approved these changes Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 51.46% and project coverage change: -0.52 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (d7bfe55) 50.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   51.30%   50.79%   -0.52%     
==========================================
  Files         318      385      +67     
  Lines       32418    36504    +4086     
==========================================
+ Hits        16632    18541    +1909     
- Misses      13840    15862    +2022     
- Partials     1946     2101     +155     
Flag Coverage Δ
unittest 50.79% <51.46%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
...gent/app/options/dynamic/adminqos/adminqos_base.go 76.92% <ø> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <0.00%> (ø)
...g/agent/qrm-plugins/network/staticpolicy/policy.go 49.61% <ø> (ø)
pkg/agent/qrm-plugins/network/staticpolicy/util.go 67.44% <ø> (ø)
... and 173 more

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csfldf csfldf added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 21, 2023
@waynepeking348 waynepeking348 merged commit 87b5bac into kubewharf:main Jun 21, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants