Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): fix numa_binding hint calculation #115

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Jun 20, 2023

What type of PR is this?

fix(qrm): fix numa_binding hint calculation

@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Jun 20, 2023
@csfldf csfldf self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 51.80% and project coverage change: -0.53 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (440dde5) 50.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   51.30%   50.77%   -0.53%     
==========================================
  Files         318      385      +67     
  Lines       32418    36516    +4098     
==========================================
+ Hits        16632    18541    +1909     
- Misses      13840    15869    +2029     
- Partials     1946     2106     +160     
Flag Coverage Δ
unittest 50.77% <51.80%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 65.94% <ø> (-4.35%) ⬇️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 198 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csfldf csfldf force-pushed the dev/fix_numa_binding_hint branch 4 times, most recently from 0a4135c to ae5486a Compare June 21, 2023 10:00
waynepeking348
waynepeking348 previously approved these changes Jun 21, 2023
@csfldf csfldf requested a review from sun-yuliang June 21, 2023 10:16
@csfldf csfldf added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 21, 2023
@waynepeking348 waynepeking348 merged commit e1e2f32 into kubewharf:main Jun 21, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants