Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysadvisor): fix sequential bugs in pid controller #116

Merged

Conversation

sun-yuliang
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

fix sequential bugs that previous values are not effective in pid controller.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@sun-yuliang sun-yuliang added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Jun 21, 2023
@sun-yuliang sun-yuliang self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 51.89% and project coverage change: -0.48 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (56370a9) 50.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   51.30%   50.83%   -0.48%     
==========================================
  Files         318      385      +67     
  Lines       32418    36491    +4073     
==========================================
+ Hits        16632    18550    +1918     
- Misses      13840    15845    +2005     
- Partials     1946     2096     +150     
Flag Coverage Δ
unittest 50.83% <51.89%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 70.28% <ø> (ø)
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 198 more

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit a6bc282 into kubewharf:main Jun 21, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants