Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase rama policy robustness #117

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

sun-yuliang
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Increase rama policy robustness for several cases.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@sun-yuliang sun-yuliang added enhancement New feature or request workflow/draft draft: no need to review labels Jun 25, 2023
@sun-yuliang sun-yuliang self-assigned this Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 51.80% and project coverage change: -0.71 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (fa870bd) 50.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   51.30%   50.60%   -0.71%     
==========================================
  Files         318      385      +67     
  Lines       32418    36581    +4163     
==========================================
+ Hits        16632    18510    +1878     
- Misses      13840    15971    +2131     
- Partials     1946     2100     +154     
Flag Coverage Δ
unittest 50.60% <51.80%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 70.28% <ø> (ø)
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.34% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 197 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sun-yuliang sun-yuliang force-pushed the syl/enhance-rama-policy branch 7 times, most recently from e11f878 to 4071e55 Compare June 26, 2023 09:29
@sun-yuliang sun-yuliang added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Jun 26, 2023
@sun-yuliang sun-yuliang changed the title WIP: increase rama policy robustness increase rama policy robustness Jun 26, 2023
@sun-yuliang sun-yuliang force-pushed the syl/enhance-rama-policy branch from 4071e55 to fa870bd Compare June 27, 2023 03:14
@sun-yuliang sun-yuliang added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jun 28, 2023
@waynepeking348 waynepeking348 merged commit a1c11cd into kubewharf:main Jun 28, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants