add headroom policy and assembler for dedicated #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun-yuliang
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 51.30% 50.85% -0.45%
==========================================
Files 318 387 +69
Lines 32418 36999 +4581
==========================================
+ Hits 16632 18817 +2185
- Misses 13840 16056 +2216
- Partials 1946 2126 +180
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sun-yuliang
changed the title
sun-yuliang
added
workflow/need-review
sun-yuliang
force-pushed
the
syl/add-headroom-policy-and-assembler-for-dedicated
branch
2 times, most recently
from
6536051 to
63e3f24
Compare
| ) | ||
|
|
||
| type HeadroomAssembler interface { | ||
| GetHeadroom() (resource.Quantity, error) | ||
| } | ||
|
|
||
| type InitFunc func(conf *config.Configuration, extraConf interface{}, regionMap *map[string]region.QoSRegion, | ||
| reservedForReclaim *map[int]int, numaAvailable *map[int]int, nonBindingNumas *machine.CPUSet, |
There was a problem hiding this comment.
why should we use map pointer here? does it mean that we will depend on this pointer to get the latest version for the map (which is not proper actually)? why not put those info in metacache?
cheney-lin
previously approved these changes
Jun 29, 2023
sun-yuliang
force-pushed
the
syl/add-headroom-policy-and-assembler-for-dedicated
branch
from
68a739f to
6ccf5fe
Compare
waynepeking348
approved these changes
Jun 29, 2023
sun-yuliang
added
the
workflow/merge-ready
cheney-lin
approved these changes
Jul 3, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Add a headroom policy based on load and headroom assembler for scene with dedicated containers.
Which issue(s) this PR fixes:
Special notes for your reviewer: